eaw/u-boot
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

spi: ti_qspi: Fix "spi-max-frequency" error path in ti_qspi_ofdata_to_platdata

Browse Source 
struct ti_qspi_priv->max_hz is declared as unsigned int, so the following
error path check will always be false, even when "spi-max-frequency"
property is invalid/missing:
  priv->max_hz = fdtdec_get_int(blob, node, "spi-max-frequency", -1);
  if (priv->max_hz < 0) {
    ...
  }

Replace the fdtdec call with dev_read_u32_default() and use 0 as the
default value. Error out if max_hz is zero.

Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
This commit is contained in:
Ovidiu Panait
2020-11-28 10:11:28 +02:00
committed by Lokesh Vutla
parent 49b4c54bc9
commit 705082d4b1
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/spi/ti_qspi.c
View File

@@ -467,8 +467,8 @@ static int ti_qspi_of_to_plat(struct udevice *bus)
priv->memory_map = map_physmem(mmap_addr, mmap_size, MAP_NOCACHE);
priv->mmap_size = mmap_size;
priv->max_hz = fdtdec_get_int(blob, node, "spi-max-frequency", -1);
if (priv->max_hz < 0) {
priv->max_hz = dev_read_u32_default(bus, "spi-max-frequency", 0);
if (!priv->max_hz) {
debug("Error: Max frequency missing\n");
return -ENODEV;
}