tools: kwboot: Use a function to check whether received byte is a Xmodem reply

This is a non-functional change that should make the code more readable.

Signed-off-by: Marek Behún <marek.behun@nic.cz>
Reviewed-by: Stefan Roese <sr@denx.de>
This commit is contained in:
Marek Behún
2021-09-24 23:06:49 +02:00
committed by Stefan Roese
parent 2ef87f75d1
commit 408ea6138b

View File

@@ -375,6 +375,12 @@ kwboot_xm_makeblock(struct kwboot_block *block, const void *data,
return n;
}
static int
_is_xm_reply(char c)
{
return c == ACK || c == NAK || c == CAN;
}
static int
kwboot_xm_sendblock(int fd, struct kwboot_block *block)
{
@@ -395,10 +401,10 @@ kwboot_xm_sendblock(int fd, struct kwboot_block *block)
c = NAK;
}
if (c != ACK && c != NAK && c != CAN)
if (!_is_xm_reply(c))
printf("%c", c);
} while (c != ACK && c != NAK && c != CAN);
} while (!_is_xm_reply(c));
if (c != ACK)
kwboot_progress(-1, '+');