From 1cc3475b1d19456dabedc8e6c8ed713a56fcab30 Mon Sep 17 00:00:00 2001
From: self_slaughter <selF_slaughter@hotmail.com>
Date: Thu, 7 Nov 2019 21:15:28 +1000
Subject: [PATCH 1/3] 1.4 - Show fails on screen / Generate report

---
 other_authors/build_mame_roms.sh | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/other_authors/build_mame_roms.sh b/other_authors/build_mame_roms.sh
index 5ff997f..c6594dc 100644
--- a/other_authors/build_mame_roms.sh
+++ b/other_authors/build_mame_roms.sh
@@ -15,6 +15,7 @@
 
 # Copyright 2019 "self_slaughter"
 
+# Version 1.4 - 2019-11-07 - Show fails on screen / Generate report
 # Version 1.3 - 2019-11-07 - More special cases / More ini options
 # Version 1.2 - 2019-10-27 - Handle special cases
 # Version 1.1 - 2019-10-05 - Read mame dir from ini file instead of editing script directly
@@ -238,6 +239,19 @@ show_stats()
     echo "Unverified:  ${#unverified[@]}"
     echo "Failed:      ${#failed[@]}"
     echo "Skipped:     ${#skipped[@]}"
+    echo ""
+    echo "Fails: ${failed[@]}"
+}
+
+save_log()
+{
+    LOG_FILE="${0%.*}.log"
+    echo "" >> "$LOG_FILE"
+    date >> "$LOG_FILE"
+    echo "- Verified (${#verified[@]}): ${verified[@]}" >> "$LOG_FILE"
+    echo "- Unverified (${#unverified[@]}): ${unverified[@]}" >> "$LOG_FILE"
+    echo "- Failed (${#failed[@]}): ${failed[@]}" >> "$LOG_FILE"
+    echo "- Skipped (${#skipped[@]}): ${skipped[@]}" >> "$LOG_FILE"
 }
 
 read_ini
@@ -257,4 +271,5 @@ do
 done
 
 show_stats
+save_log
 cleanup

From 985f30b146e043013c41cd871ffe5172b8b87ad5 Mon Sep 17 00:00:00 2001
From: self_slaughter <selF_slaughter@hotmail.com>
Date: Sun, 10 Nov 2019 04:15:34 +1000
Subject: [PATCH 2/3] 1.5 - Attempt to future proof alt rom creation

---
 other_authors/build_mame_roms.sh | 40 +++++++++++++++-----------------
 1 file changed, 19 insertions(+), 21 deletions(-)

diff --git a/other_authors/build_mame_roms.sh b/other_authors/build_mame_roms.sh
index c6594dc..d26e07c 100644
--- a/other_authors/build_mame_roms.sh
+++ b/other_authors/build_mame_roms.sh
@@ -15,6 +15,7 @@
 
 # Copyright 2019 "self_slaughter"
 
+# Version 1.5 - 2019-11-10 - Attempt to future proof alt rom creation
 # Version 1.4 - 2019-11-07 - Show fails on screen / Generate report
 # Version 1.3 - 2019-11-07 - More special cases / More ini options
 # Version 1.2 - 2019-10-27 - Handle special cases
@@ -187,6 +188,7 @@ grab_zips()
 build_roms()
 {
     cd "$WORK_DIR/${CORE_NAME[$1]}"
+    scriptCount=$(ls *.sh | wc -l)
     for buildScript in *.sh; do
         source "$WORK_DIR/${CORE_NAME[$1]}/${buildScript%.*}.ini"
         echo "- Building ROM"
@@ -206,28 +208,24 @@ build_roms()
             fi
         fi
 
-# more special case handling
-        case ${CORE_NAME[$1]} in
-            Druaga) # alt roms
-                mkdir "$ALT_OUTPUT_DIR/a.druaga" &>/dev/null
-                if [ ! -f "$ALT_OUTPUT_DIR/a.druaga/${ofile}" ] || [ $OVERWRITE_EXISTING = "true" ]; then
-                    cp "$WORK_DIR/${CORE_NAME[$1]}/${ofile}" "$ALT_OUTPUT_DIR/a.druaga/${ofile}"
+        # handle alt roms
+        if [ $scriptCount -gt 1 ]; then
+            CORE_INTERNAL_NAME="$(curl $CURL_RETRY -sLf "${CORE_URL[$1]}/raw/master/Arcade-${CORE_NAME[$1]}.sv" | awk '/CONF_STR[^=]*=/,/;/' | grep -oE -m1 '".*?;' | sed 's/[";]//g')"
+            if [ ! "$CORE_INTERNAL_NAME" == "" ]; then
+                mkdir "$ALT_OUTPUT_DIR/$CORE_INTERNAL_NAME" &>/dev/null
+                if [ ! -f "$ALT_OUTPUT_DIR/$CORE_INTERNAL_NAME/${ofile}" ] || [ $OVERWRITE_EXISTING = "true" ]; then
+                    cp "$WORK_DIR/${CORE_NAME[$1]}/${ofile}" "$ALT_OUTPUT_DIR/$CORE_INTERNAL_NAME/${ofile}"
                 fi
-                ;;
-            RallyX) # alt roms
-                mkdir "$ALT_OUTPUT_DIR/a.nrallyx" &>/dev/null
-                if [ ! -f "$ALT_OUTPUT_DIR/a.nrallyx/${ofile}" ] || [ $OVERWRITE_EXISTING = "true" ]; then
-                    cp "$WORK_DIR/${CORE_NAME[$1]}/${ofile}" "$ALT_OUTPUT_DIR/a.nrallyx/${ofile}"
-                fi
-                ;;
-            1943) # branding issues
-                if [ "${ofile}" == "a.JT1943.rom" ]; then
-                    if [ ! -f "$OUTPUT_DIR/a.1943.rom" ] || [ $OVERWRITE_EXISTING = "true" ]; then
-                         cp "$WORK_DIR/${CORE_NAME[$1]}/${ofile}" "$OUTPUT_DIR/a.1943.rom"
-                    fi
-                fi
-                ;;
-        esac
+            fi
+        fi
+
+        #handle JT branding
+        if [ "${ofile}" == "a.JT1943.rom" ]; then
+            if [ ! -f "$OUTPUT_DIR/a.1943.rom" ] || [ $OVERWRITE_EXISTING = "true" ]; then
+                 cp "$WORK_DIR/${CORE_NAME[$1]}/${ofile}" "$OUTPUT_DIR/a.1943.rom"
+            fi
+        fi
+
         cp "$WORK_DIR/${CORE_NAME[$1]}/${ofile}" "$OUTPUT_DIR/${ofile}"
     done
 }

From 875773bac7073c8e20443a7ae365a39e61f2c9fe Mon Sep 17 00:00:00 2001
From: self_slaughter <selF_slaughter@hotmail.com>
Date: Sun, 10 Nov 2019 19:25:52 +1000
Subject: [PATCH 3/3] Remove 1943 workaround

---
 other_authors/build_mame_roms.sh | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/other_authors/build_mame_roms.sh b/other_authors/build_mame_roms.sh
index d26e07c..4219dbd 100644
--- a/other_authors/build_mame_roms.sh
+++ b/other_authors/build_mame_roms.sh
@@ -219,13 +219,6 @@ build_roms()
             fi
         fi
 
-        #handle JT branding
-        if [ "${ofile}" == "a.JT1943.rom" ]; then
-            if [ ! -f "$OUTPUT_DIR/a.1943.rom" ] || [ $OVERWRITE_EXISTING = "true" ]; then
-                 cp "$WORK_DIR/${CORE_NAME[$1]}/${ofile}" "$OUTPUT_DIR/a.1943.rom"
-            fi
-        fi
-
         cp "$WORK_DIR/${CORE_NAME[$1]}/${ofile}" "$OUTPUT_DIR/${ofile}"
     done
 }