From cd1d66c079a2fa8c3c4519ea43cd81bfebcefd8e Mon Sep 17 00:00:00 2001 From: jimmystones Date: Thu, 9 Sep 2021 14:34:08 +0100 Subject: [PATCH] Fix turning on autosave w/o core reload Previously, in order to enable autosave, you'd have to turn it on using the OSD, then Save Settings, and then reload the core. This commit fixes a bug preventing autosave from working as soon as it was turned on. The problem was that a flag was not being reset when one of the state machines exited if autosave was off, this prevented the state machine from restarting properly the next time the OSD was opened. --- README.MD | 4 ++++ hiscore.v | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/README.MD b/README.MD index fc65735..7fb0b81 100644 --- a/README.MD +++ b/README.MD @@ -6,6 +6,8 @@ Created by Alan Steremberg ([alanswx](https://github.com/alanswx)) Further development by Jim Gregory ([JimmyStones](https://github.com/jimmystones)) +Bug fixes by ([tacertain](https://github.com/tacertain)) + ### Features - Reads hiscore.dat entries from MRA (defaults to ioctl index = 3) - Loads and saves high score data in \.nvm dump (defaults to ioctl index = 4) @@ -45,6 +47,8 @@ Further development by Jim Gregory ([JimmyStones](https://github.com/jimmystones - Add variable length change detection mask #### 0013 - 2021-09-01 - Output configured signal for autosave option menu masking +#### 0013 - 2021-09-09 +- Fix turning on autosave w/o core reload (tacertain) ## Implementation instructions diff --git a/hiscore.v b/hiscore.v index 6dfdf90..5da7d55 100644 --- a/hiscore.v +++ b/hiscore.v @@ -36,6 +36,7 @@ 0011 - 2021-08-07 - Optional auto-save on OSD open 0012 - 2021-08-17 - Add variable length change detection mask 0013 - 2021-09-01 - Output configured signal for autosave option menu masking + 0014 - 2021-09-09 - Fix turning on autosave w/o core reload ============================================================================ */ @@ -158,7 +159,7 @@ Hiscore config data structure (version 1) */ -localparam HS_VERSION =13; // Version identifier for module +localparam HS_VERSION =14; // Version identifier for module localparam HS_DUMPFORMAT =1; // Version identifier for dump format localparam HS_HEADERLENGTH =16; // Size of header chunk (default=16 bytes) @@ -542,6 +543,7 @@ begin end else begin + extracting_dump <= 1'b0; state <= SM_STOPPED; end end