Arcade-Robotron_MiSTer

mirror of https://github.com/MiSTer-devel/Arcade-Robotron_MiSTer.git synced 2026-04-19 03:03:11 +00:00

Files

Kyle Owsen 702bdce620 Fix audio for SCREAM sound in Robotron and Sinistar's voice (#33 )

* Squashed commit of the following:

commit 93a34bd5b6b6c2a63502f9bfab6c22eac008d48f
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Wed Feb 25 18:36:43 2026 -0800

    Fix audio gain

commit 561501c7469d543d5e43e377ab049d02d64c8613
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Wed Feb 25 16:28:21 2026 -0800

    You take the high road

commit b4475420c04be2f72b5dbaa05ed2fb154bc74d78
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Wed Feb 25 16:26:18 2026 -0800

    Add high pass filter

commit dde194e86a887c37106c623f4adc23a4b15a5a46
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Wed Feb 25 13:53:25 2026 -0800

    Any day now they'll be here

commit a91de21560baaa6d4984ee081beaccbfb7a1b0b0
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Wed Feb 25 13:53:18 2026 -0800

    Revert "They are getting louder"

    This reverts commit f2fc5f8644d36ca4ee7aaffdb78fbe541094df45.

commit f2fc5f8644d36ca4ee7aaffdb78fbe541094df45
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Wed Feb 25 13:17:50 2026 -0800

    They are getting louder

commit d1fd795364871d6801fd8554b71f79d1e7ecce47
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Wed Feb 25 13:16:45 2026 -0800

    Revert "I am not an engineer I just hear the whispers"

    This reverts commit ecc8d9508f4ddda47f62afb16ff663703c47cea1.

commit ecc8d9508f4ddda47f62afb16ff663703c47cea1
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Wed Feb 25 12:51:08 2026 -0800

    I am not an engineer I just hear the whispers

commit 153674ad0cfc4c2f51294f61962bdf2761a4f3e1
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Wed Feb 25 12:23:39 2026 -0800

    Undo useless change

commit fc3e926bd0e0aa794782d8a7051e5abfd1c16e24
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Wed Feb 25 11:53:19 2026 -0800

    Live mas

commit 88791182c32fee13e547013b1c330b2c2bcb2f5f
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Wed Feb 25 11:52:07 2026 -0800

    Screw it, let's test both

commit 474e4d2bd4cc1fd6e1503ed0008b605b11f3b3d8
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Wed Feb 25 11:50:07 2026 -0800

    Remove last IIR filter, see if latest fix works

commit e7064d7ff8659f78f27b1ba2617c012036cf75b3
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Wed Feb 25 10:26:15 2026 -0800

    Lower sound clock to nearest whole number to slow it down and verify clock drift is why electric sound is bad

commit 8e63ee2652b23210508003038e136f9410753d5d
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Wed Feb 25 02:08:36 2026 -0800

    Fix coefficients and where we convert to 16 bit

commit 3f8d8ef9f70220060319e07469233f7d21815dc6
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Wed Feb 25 00:59:24 2026 -0800

    Fix bits in filter

commit 06290ef4b539e6067e40749b5a09adb9377132b0
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Tue Feb 24 23:58:40 2026 -0800

    Please be working

commit 00d841f05f6eb944b328f49156765ee8942130b4
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Tue Feb 24 23:18:27 2026 -0800

    Once more unto the breach

commit 5e3e23078882c478c44fa57be121911dc2625a91
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Tue Feb 24 19:27:47 2026 -0800

    Another attempt, probably fixing HYPER but not boot

commit 12e8269add34c8cf325e52a08dea5c57e7b3f33d
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Tue Feb 24 01:55:28 2026 -0800

    Add boxcar filter

commit d582136e77995dd99f8d5a0e58acdad2d2fec73e
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Mon Feb 23 17:41:42 2026 -0800

    Attempt to fix startup sound and HYPER sound again

commit 0d7f352ba9686706e19d196745fb60b96474acd5
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Mon Feb 23 17:23:55 2026 -0800

    Revert "Here we go again (boot sound)"

    This reverts commit 5589465c66c85ed40cfe8a5d059cce31c03bac9a.

commit 5589465c66c85ed40cfe8a5d059cce31c03bac9a
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Mon Feb 23 15:11:38 2026 -0800

    Here we go again (boot sound)

commit d5e1ae777276e276e539017c5ff8d78ccae58f9a
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Mon Feb 23 15:06:37 2026 -0800

    Revert "Attempt 3 at boot sound trigger"

    This reverts commit d242cedf5f9e796f0a1da560025cc4fe0a35221c.

commit 264c4d8485c3486f6a5b9225e566962e36e857e1
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Mon Feb 23 14:00:12 2026 -0800

    Revert "Fix STAA timing"

    This reverts commit d0d4ecdda28e6f9f0d1fa48a3b55acc6eaa38857.

commit d242cedf5f9e796f0a1da560025cc4fe0a35221c
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Mon Feb 23 13:54:55 2026 -0800

    Attempt 3 at boot sound trigger

commit d0d4ecdda28e6f9f0d1fa48a3b55acc6eaa38857
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Mon Feb 23 13:41:57 2026 -0800

    Fix STAA timing

commit ad12e4c9043c80442692c91391aff1736982c1de
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Mon Feb 23 13:39:18 2026 -0800

    Revert "Attempt 2 at boot sound trigger"

    This reverts commit adf8fb35ce7883f33e9dd2440f5e154b433d8dfa.

commit 4e4d83d5a1df4071103604b29c1d64f703e9a77f
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Mon Feb 23 01:56:29 2026 -0800

    Hopefully fix jmp addresses

commit c3527b1427c1990d507b0a78b255e90eb5665b04
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Mon Feb 23 01:52:19 2026 -0800

    Reapply "Make jmp 3 cycles"

    This reverts commit a1d17eddd9d940aedf9521a0c5a90a8d58858073.

commit a1d17eddd9d940aedf9521a0c5a90a8d58858073
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Mon Feb 23 01:45:57 2026 -0800

    Revert "Make jmp 3 cycles"

    This reverts commit 11b6576c52117d5e1d4a05eb658bd48695648d42.

commit adf8fb35ce7883f33e9dd2440f5e154b433d8dfa
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Mon Feb 23 01:31:07 2026 -0800

    Attempt 2 at boot sound trigger

commit d4a686e6fd971697209e74916a6aed016fecba77
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Mon Feb 23 01:29:23 2026 -0800

    Revert "Hack for initial sound"

    This reverts commit 25ef7b827766cdddbb525849b606cdfc24a76f8e.

commit 11b6576c52117d5e1d4a05eb658bd48695648d42
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Mon Feb 23 01:08:25 2026 -0800

    Make jmp 3 cycles

commit 25ef7b827766cdddbb525849b606cdfc24a76f8e
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Mon Feb 23 00:55:20 2026 -0800

    Hack for initial sound

commit b467bd36fdabf8c5e1c6615f252a71d3cfca3dd4
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Mon Feb 23 00:20:15 2026 -0800

    Fix bsr timing

commit 5a56beff8823145b2fd1d5b97a33275d880d9d61
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sun Feb 22 23:02:55 2026 -0800

    Fix tst cycles

commit e19c32ca0d0d32d0bf3107bd63af4a2a13a9d4bd
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sun Feb 22 19:49:09 2026 -0800

    Revert "Try removing gain and maybe fixing flags"

    This reverts commit 45c5cf64d88d1a70ac320f45ff02af4c306d98ee.

commit 45c5cf64d88d1a70ac320f45ff02af4c306d98ee
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sun Feb 22 19:25:08 2026 -0800

    Try removing gain and maybe fixing flags

commit b23236770132464abc7b9df49d88fcf9cbdcbbc6
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sun Feb 22 18:24:37 2026 -0800

    Revert "Bump down low pass filter for sinistar voice"

    This reverts commit 8b622c40fae92e8aad06f751b39b0b442915ee19.

commit 8b622c40fae92e8aad06f751b39b0b442915ee19
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sun Feb 22 17:47:39 2026 -0800

    Bump down low pass filter for sinistar voice

commit a0217b7ed814d0a0b5f86bc23949f03dde0aaff1
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sun Feb 22 17:11:35 2026 -0800

    Small timing fix

commit 18f0442146ef9f6ff9ad789316a2940719cf07a3
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sun Feb 22 16:59:59 2026 -0800

    Remove half done change for adding more bits

commit 197ccbf89c81b377e8f019efdf3c26c18747d650
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sun Feb 22 16:57:16 2026 -0800

    Actually stage changes I meant to

commit 2d14ef086354eb5a8d22b9b7691ff7b9a2869a63
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sun Feb 22 16:56:48 2026 -0800

    Attempt rewrite of CVSD to match Mame

commit ff2c5dcfd64dee1b08bc12c1fcb9282885da7f0d
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sun Feb 22 16:13:53 2026 -0800

    Clamp sinistar filter

commit 18ce84a07f34891bdb3f36640719c095816490ba
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sun Feb 22 01:54:49 2026 -0800

    Don't try adding gain inside filter passes

commit 7ea29095254c9f2c8ed1237cd31d207fdda14867
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sun Feb 22 01:34:04 2026 -0800

    Try to prevent sinistar filter from clipping

commit 6ac653b86487b6ffb14b966c8262a5c090533fc0
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sun Feb 22 01:19:36 2026 -0800

    Boost gain on voice to match diagram

commit 6d60e9675908d48f3ea804a78572940d3205b4be
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sun Feb 22 00:32:41 2026 -0800

    Attempt at filter from schematics

commit 7b0857009c3e3f93d5598f6173d073c7c026974d
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sat Feb 21 23:42:13 2026 -0800

    Attempt at more accurate sinistar low pass filter

commit e0b21fbe7ad41c1e9fa47d30c5da3b18a8067a52
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sat Feb 21 22:08:48 2026 -0800

    Remove gitignore changes

commit 5557de02512e22414638f55e0f062437b2543673
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sat Feb 21 22:08:20 2026 -0800

    Remove extra comment and newline

commit c65203729fbdd6a662a18fd31742092fed032462
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sat Feb 21 22:06:27 2026 -0800

    Update filter coefficient values

commit 9d5ce8be85896e28caeb068eea71c9e27654b48d
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sat Feb 21 21:46:47 2026 -0800

    Final timing fixes

commit 27151777e9c9422c8fad0646034d9ba8d4845364
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sat Feb 21 21:03:07 2026 -0800

    Revert startup sound changes

commit fa74a8a2bdd1a12b9c3be578a9ae1cf0fb83ff2b
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sat Feb 21 21:02:14 2026 -0800

    Rename files

commit 0f2e69943bad070c3bf13787cbd7f26ba940ce4c
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sat Feb 21 20:26:25 2026 -0800

    Undo comment changes

commit 3aa3a7d6d02395a4e3c925ac43a5ee919397e4ad
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sat Feb 21 20:22:31 2026 -0800

    Attempt to fix compilation

commit 9a25d62a6242653a780e24028f21f4bb9fc335bd
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sat Feb 21 20:18:06 2026 -0800

    Add new sinistar filter

commit 1e71f1dd582ab25aaf1d4ef4278083bcce5fa67e
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sat Feb 21 20:09:26 2026 -0800

    Revert invalid CVSD filter

commit ecc7e30c71fc85652fa4763fddb6977f7d9d7e76
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sat Feb 21 20:01:29 2026 -0800

    Fix Robotron startup sound timing by staggering CPU resets

commit 4730fce91887f96a9c2a32316e5830d18824b158
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sat Feb 21 19:52:33 2026 -0800

    Undo bad change

commit 2f5fcf241af33d88862bdc44180a7c6e282fe15d
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sat Feb 21 19:39:36 2026 -0800

    Sinistar low pass filter change and 16 bit instruction tweak

commit f3cb66e024015936f501d3c24ae5216926598f77
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sat Feb 21 14:29:37 2026 -0800

    Add low pass filter for Sinistar speech

commit 4bcfd723b96f5f8d0ba3be07e991fc16d838e7bd
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sat Feb 21 13:53:03 2026 -0800

    Update formatting and comments

commit 9e2fe2f07d16f0f10070a4291ba3416a4aeb3b83
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sat Feb 21 13:22:06 2026 -0800

    More timing fixes

commit 59a2efd1cba84db329763dfe5f642cc425c23fa8
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sat Feb 21 13:08:54 2026 -0800

    Add additional stalls

commit 8ba7df9362ccef3e1147ef72305dd55c56fea63c
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Sat Feb 21 12:52:08 2026 -0800

    Fix single operand stall logic to correctly distinguish extended (no stall) from indexed (1-cycle stall)

commit bae6bd2fe691a3550aa852707dd4ff69ce94c057
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Fri Feb 20 18:57:45 2026 -0800

    Add additional timing fixes

commit 4969fd63eeaa09ceebc5cb314734a2a1b68c0929
Author: Kyle Owsen <kyle.owsen@gmail.com>
Date:   Fri Feb 20 02:08:00 2026 -0800

    Update inx / ins / des / lsr / inc cycle accuracy

    This commit fixes instruction timing inaccuracies in the cpu68 core that
    were causing software-timed pitch loops, such as the 'humanoid fall'
    sound in Robotron and Defender, to play too quickly and at too high a pitch.

    - lsr / inc: Used in the tight inner loop of the sound generation calculation.
      By injecting a stall_write_state before the write cycle, these extended/indexed
      single-operand memory instructions now correctly take 6 cycles instead of 5,
      slowing down the PCM pitch loop to match real hardware.

    - inx: Heavily used in the outer loops to iterate through sound calculation pairs.
      By transitioning to stall2_state instead of fetch_state, inx now takes the
      accurate 4 cycles instead of finishing incorrectly in 2 cycles, further
      slowing down the pitch generation loops.

    - ins / des: Fixed alongside inx for structural cycle-accuracy completeness (2 to 4 cycles).

* Revert "Any day now they'll be here"

This reverts commit dde194e86a887c37106c623f4adc23a4b15a5a46.

* Add release

* Remove extra comments

* Add attribution to be a good citizen