Marek Behún d32211ee95
api: fix a potential serious bug caused by undef CONFIG_SYS_64BIT_LBA ...
The api_public.h header file undefined macro CONFIG_SYS_64BIT_LBA.
But api/api_storage.c includes this header before including part.h,
causing the type of lbaint_t and subsequently the type signature of
blk_dread() and blk_dwrite() functions to change from the rest of U-Boot
(if CONFIG_SYS_64BIT_LBA is defined for the board).
This is of course wrong, because the call to blk_dread() / blk_dwrite()
will receive mangled arguments.
Fix this by removing the undef of macro CONFIG_SYS_64BIT_LBA and instead
make the immediate code do what it would do as if the macro was not
defined.
Add a FIXME to whoever is maintaining this code.
CI managed to trigger this bug when compiling for lsxhl_defconfig, which
has CONFIG_API selected. The compiler complained about blk_dwrite() and
blk_dread() not matching original declarations:
include/blk.h:280:15: warning: type of ‘blk_dwrite’ does not match
original declaration
[-Wlto-type-mismatch]
280 | unsigned long blk_dwrite(struct blk_desc *block_dev, lbaint_t st
| ^
drivers/block/blk-uclass.c:456:15: note: type mismatch in parameter 2
456 | unsigned long blk_dwrite(struct blk_desc *block_dev, lbaint_t st
| ^
Signed-off-by: Marek Behún <marek.behun@nic.cz >
Reviewed-by: Simon Glass <sjg@chromium.org >
2021-03-19 10:36:06 -04:00
2021-02-01 15:11:41 +08:00
2021-02-06 19:20:27 +08:00
2020-05-18 18:36:55 -04:00
2020-09-09 16:57:35 -04:00
2021-03-15 08:43:29 -04:00
2020-07-22 12:37:17 +02:00
2021-02-18 11:56:25 +01:00
2021-02-07 21:12:56 +01:00
2020-10-12 07:26:57 -04:00
2020-05-18 21:19:23 -04:00
2020-07-17 09:30:13 -04:00
2020-08-25 09:33:35 +08:00
2019-12-06 16:44:20 -05:00
2021-03-01 09:54:11 -05:00
2019-10-16 05:42:27 +02:00
2021-02-16 11:48:20 -05:00
2021-02-02 15:33:42 -05:00
2021-02-16 11:48:20 -05:00
2021-03-05 10:25:43 +05:30
2021-02-24 16:51:48 -05:00
2021-02-18 11:56:26 +01:00
2020-10-23 09:16:01 -04:00
2021-02-21 06:08:00 +01:00
2020-12-13 16:51:08 -07:00
2021-03-05 10:25:43 +05:30
2020-10-09 17:53:12 +08:00
2020-05-18 17:33:33 -04:00
2019-10-15 09:56:04 -04:00
2020-05-11 10:16:49 +05:30
2021-03-19 10:36:06 -04:00
2021-01-15 14:36:12 -05:00
2020-04-17 12:32:36 -04:00
2020-12-04 16:09:06 -05:00
2020-12-13 16:51:09 -07:00
2021-02-02 15:33:42 -05:00
2020-08-24 14:11:13 -04:00
2021-02-02 15:33:42 -05:00
2021-01-25 21:52:00 +00:00
2021-01-25 21:52:00 +00:00
2021-02-02 15:33:42 -05:00
2021-01-31 14:08:56 +01:00
2020-11-05 09:11:31 -07:00
2021-01-27 17:03:16 -05:00
2020-05-18 21:19:23 -04:00
2020-12-13 16:51:08 -07:00
2021-01-27 17:03:16 -05:00
2021-02-02 15:33:42 -05:00
2020-12-04 19:48:29 -05:00
2020-07-09 12:33:24 +08:00
2020-04-22 20:41:56 +08:00
2020-05-18 17:33:33 -04:00
2021-02-22 11:07:57 +01:00
2021-02-02 15:33:42 -05:00
2020-05-27 14:40:09 +08:00
2021-03-07 17:37:13 +01:00
2020-12-04 16:10:01 -05:00
2021-01-12 10:58:04 +05:30
2021-01-12 10:58:04 +05:30
2020-01-24 23:06:48 +05:30
2021-02-03 23:16:44 +08:00
2021-02-02 15:33:42 -05:00
2020-12-26 12:37:28 +01:00
2021-01-20 08:09:34 +01:00
2021-02-21 06:08:00 +01:00
2020-05-18 21:19:23 -04:00
2020-04-28 15:57:58 -04:00
2020-10-29 14:42:17 -06:00
2021-01-15 14:38:00 -05:00
2019-11-04 12:56:37 -05:00
2020-05-18 18:36:55 -04:00
2021-02-02 15:33:42 -05:00
2021-01-30 14:25:41 -07:00
2021-01-30 14:25:42 -07:00
2020-07-08 17:21:46 -04:00
2021-01-31 14:08:56 +01:00
2020-10-22 09:54:54 -04:00
2020-08-03 22:19:54 -04:00
2020-08-03 22:19:54 -04:00
2020-02-05 19:33:46 -07:00
2021-02-02 15:33:42 -05:00
2020-10-29 14:42:18 -06:00
2020-12-09 10:57:50 +01:00
2020-05-29 18:13:19 +08:00
2021-01-15 17:48:36 +08:00
2020-01-16 13:16:25 +08:00
2021-01-30 14:25:41 -07:00
2020-05-07 09:01:42 -04:00
2021-01-20 08:17:17 +01:00
2020-08-03 22:19:54 -04:00
2021-01-13 02:38:01 +01:00
2020-02-28 19:37:14 +01:00
2021-02-26 16:17:43 +01:00
2020-01-07 18:08:22 +01:00
2020-05-09 09:30:28 +02:00
2020-12-03 21:22:40 +01:00
2021-01-20 08:17:17 +01:00
2021-01-13 02:38:01 +01:00
2020-05-18 21:19:23 -04:00
2020-04-24 10:09:59 -04:00
2021-02-08 08:52:50 +01:00
2020-07-31 10:13:00 -04:00
2021-02-08 08:52:50 +01:00
2020-10-30 10:54:38 -04:00
2019-10-31 07:22:53 -04:00
2020-08-03 22:19:54 -04:00
2020-05-18 18:36:55 -04:00
2021-02-21 06:08:00 +01:00
2020-05-18 17:33:33 -04:00
2021-02-02 15:33:42 -05:00
2021-02-26 15:30:55 +01:00
2021-01-23 07:56:53 +01:00
2020-05-18 17:33:33 -04:00
2020-04-26 14:24:08 -06:00
2021-02-18 11:56:25 +01:00
2020-09-22 12:54:13 -06:00
2020-05-18 14:53:28 -04:00
2020-07-17 09:30:13 -04:00
2020-05-18 17:33:33 -04:00
2020-12-13 16:51:09 -07:00
2020-08-07 22:31:32 -04:00
2020-05-18 18:36:55 -04:00
2020-07-27 14:16:26 +05:30
2020-07-17 09:30:13 -04:00
2020-11-28 10:39:44 +08:00
2020-12-10 13:56:39 +05:30
2020-01-14 22:54:00 +01:00
2020-09-24 08:27:44 -04:00
2021-02-02 15:33:42 -05:00
2020-07-27 14:16:29 +05:30
2020-05-18 18:36:55 -04:00
2020-05-14 09:02:12 +02:00
2021-02-10 10:00:51 +01:00
2020-10-30 10:56:11 -04:00
2020-05-18 17:33:33 -04:00
2020-08-26 09:19:16 +02:00
2020-01-24 23:06:49 +05:30
2020-06-12 13:14:07 -04:00
2019-11-12 23:13:54 +01:00
2020-03-16 08:03:05 +01:00
2021-02-21 06:08:00 +01:00
2021-02-02 15:33:42 -05:00
2021-03-17 12:50:19 -04:00
2020-04-24 10:10:00 -04:00
2019-10-14 09:31:41 +02:00
2020-05-01 13:46:21 +02:00
2020-01-20 15:38:16 +01:00
2021-02-15 10:16:45 -05:00
2021-02-02 15:33:42 -05:00
2021-02-16 11:16:08 -05:00
2019-12-02 18:25:01 -05:00
2020-07-17 14:32:24 +08:00
2019-11-07 18:39:16 -05:00
2020-05-18 18:36:55 -04:00
2021-02-02 15:33:42 -05:00
2020-04-17 12:32:36 -04:00
2020-12-18 20:32:21 -07:00
2020-08-04 23:30:02 -04:00
2021-01-16 19:17:11 -05:00
2019-12-02 18:23:11 -05:00
2020-02-05 19:33:46 -07:00
2021-02-24 16:51:48 -05:00
2020-05-07 09:01:42 -04:00
2020-05-01 13:46:22 +02:00
2021-01-15 14:36:12 -05:00
2020-10-18 10:36:05 +02:00
2021-02-02 15:33:42 -05:00
2020-11-29 05:18:37 +01:00
2021-02-19 15:10:41 +08:00
2020-05-19 14:01:47 -04:00
2020-01-25 12:04:36 -05:00
2020-10-28 11:48:32 -04:00
2020-10-28 11:48:55 -04:00
2020-07-17 09:30:13 -04:00
2020-05-10 20:55:20 +02:00
2020-07-08 17:21:46 -04:00
2021-02-16 11:48:20 -05:00
2021-02-02 15:33:42 -05:00
2021-01-05 12:24:40 -07:00
2020-09-15 18:51:53 +05:30
2019-12-10 08:23:10 +08:00
2021-02-03 03:38:41 -07:00
2020-12-13 16:51:09 -07:00
2021-02-21 06:08:00 +01:00
2021-01-16 14:49:09 -05:00
2021-02-26 15:30:55 +01:00
2020-05-18 21:19:23 -04:00
2020-07-17 10:47:19 -04:00
2020-12-18 20:32:21 -07:00
2020-01-07 18:08:19 +01:00
2020-08-03 22:19:54 -04:00
2021-02-10 10:00:51 +01:00
2021-02-16 11:48:20 -05:00
2021-02-18 11:56:25 +01:00
2021-01-15 14:36:11 -05:00
2020-02-05 19:33:46 -07:00
2019-10-15 08:40:03 -06:00
2020-08-14 15:18:30 -04:00
2021-02-02 15:33:42 -05:00
2019-12-15 11:44:25 +08:00
2021-02-02 15:33:42 -05:00
2020-06-14 21:07:20 +02:00
2020-12-13 16:51:09 -07:00
2020-05-18 17:33:33 -04:00
2020-12-13 16:51:08 -07:00
2020-02-05 19:33:46 -07:00
2020-09-30 11:55:22 -04:00
2020-06-14 21:07:20 +02:00
2020-07-09 06:02:44 +02:00
2020-08-24 11:03:26 +02:00
2020-05-18 17:33:33 -04:00
2020-09-30 11:55:23 -04:00
2020-09-30 11:55:23 -04:00
2020-09-30 11:55:23 -04:00
2021-02-02 15:33:42 -05:00
2021-02-04 20:37:57 +05:30
2020-12-04 16:09:06 -05:00
2020-08-06 14:27:27 -04:00
2020-12-31 14:41:31 +01:00
2021-02-06 19:20:27 +08:00
2021-02-02 15:33:42 -05:00
2019-12-02 18:23:08 -05:00
2020-02-05 19:33:46 -07:00
2020-08-03 22:19:54 -04:00
2021-02-08 14:01:18 +05:30
2021-01-05 16:20:26 -05:00
2021-02-17 17:12:45 -05:00
2020-11-19 09:45:49 -05:00
2019-12-02 18:23:06 -05:00
2021-02-16 11:16:07 -05:00
2020-10-22 09:54:53 -04:00
2020-12-09 10:57:50 +01:00
2021-01-11 23:19:33 +00:00
2020-12-13 16:51:09 -07:00
2021-02-15 10:16:45 -05:00
2021-02-02 15:33:42 -05:00
2021-02-02 15:33:42 -05:00
2020-08-03 22:19:54 -04:00
2021-01-31 14:08:56 +01:00
2020-07-17 14:32:24 +08:00
2020-10-22 09:54:53 -04:00
2020-01-21 15:56:15 +01:00
2021-02-02 15:33:42 -05:00
2021-02-02 15:33:42 -05:00
2021-02-02 15:33:42 -05:00
2021-02-02 15:33:42 -05:00
2020-09-24 08:27:44 -04:00
2021-02-21 06:08:00 +01:00
2021-02-21 06:08:00 +01:00
2020-05-18 17:33:33 -04:00
2020-01-17 10:15:49 -05:00
2021-02-02 15:33:42 -05:00
2020-09-01 14:47:43 +02:00
2020-12-13 16:51:09 -07:00
2021-01-31 14:08:56 +01:00
2021-01-27 17:03:16 -05:00
2020-12-13 16:51:09 -07:00
2020-07-09 12:33:24 +08:00
2021-02-22 20:06:43 +01:00
2021-01-27 17:03:16 -05:00
2021-01-05 12:24:41 -07:00
2020-07-17 09:30:13 -04:00
2020-08-14 15:18:30 -04:00
2020-05-18 18:36:55 -04:00
2020-08-03 22:19:54 -04:00
2020-05-18 21:19:18 -04:00
2020-08-03 22:19:54 -04:00
2021-01-15 14:36:12 -05:00
2020-05-18 21:19:23 -04:00
2020-06-23 14:43:23 -04:00
2020-08-20 10:57:46 +02:00
2020-10-29 08:55:43 +01:00
2020-09-23 10:31:41 +02:00
2020-06-24 13:07:57 +02:00
d32211ee95