Files
u-boot/include
Eugeniu Rosca d08b16edf8 image.h: isolate android_image_* functions from tooling
On Feb. 16, 2020, Tom reported [1] build failure of U-Boot in-tree
tooling after applying https://patchwork.ozlabs.org/cover/1229663/
("[v6,0/7] rsa: extend rsa_verify() for UEFI secure boot").

Later on, Heinrich stressed the urgency of the issue in
https://patchwork.ozlabs.org/patch/1250858/#2379069:

 >>>>>>>>>
 We should finalize the topic as it stops EFI patches from being merged
 >>>>>>>>>

On the surface, the problem is caused by U-Boot commits [2-3], which
employed 'u32' in 'include/image.h', while historically U-Boot tooling
stayed agnostic on the {u,s}{8,16,32} types.

Thanks to Tom, Yamada-san and Heinrich, the following solutions have
been put head-to-head ('+' pros, '-' cons):

 A. Use an equivalent fixed-size type, i.e. s/u32/uint32_t/ in both
    android function prototypes (image.h) and definitions (c file):
    + quick and low-line-count
    - creates a 'soup' of fixed-sized types in the Android C file
    - will confuse contributors
    - is going against Linux kernel best practices [4]

 B. Guard Android functions by '!defined(USE_HOSTCC)' in image.h:
    + quick and low-line-count
    + reflects the reality (no android function is used by tooling)
    + zero impact on other subsystems
    - ifdeffery may look annoying (pre-existing problem of image.h)

 C. Make {u8,u16,u32} available in U-Boot tooling:
    + quick and low-line-count
    + [Yamada-san][5]:
      * forbidding u32 for tools is questionable to me
      * Linux kernel and Barebox use {u8,u16,u32} for the tools space
    - breaks U-Boot tradition?
    - has larger impact than [A] and [B]
    - adds type complexity/inconsistency in the tooling space

 D. [Yamada-san] Refactor the headers to minimize the code shared
    between U-Boot space and tooling space:
    + probably the long-term solution
    - high effort
    - can be seen/done as an incremental update on top of [B]

Looking at the above, [B] looks like the natural way to go forward.

[1] https://patchwork.ozlabs.org/patch/1238245/#2363052
[2] commit 7f2531502c ("image: android: Add routine to get dtbo params")
[3] commit c3bfad825a ("image: android: Add functions for handling dtb field")
[4] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e6176fa4728fb6d
    ("checkpatch: add --strict warning for c99 fixed size typedefs : int<size>_t")
[5] https://patchwork.ozlabs.org/patch/1238245/#2363340

Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Sam Protsenko <joe.skb7@gmail.com>
Cc: Lokesh Vutla <lokeshvutla@ti.com>
Cc: Simon Glass <sjg@chromium.org>
Cc: AKASHI Takahiro <takahiro.akashi@linaro.org>
Reported-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
Tested-by: Heinrich Schuchardt <xpyron.glpk@gmx.de>
2020-03-12 08:20:38 -04:00
..
2017-07-03 17:35:28 -04:00
2019-12-06 16:44:20 -05:00
2019-10-16 05:42:27 +02:00
2016-04-01 17:18:12 -04:00
2019-11-17 17:22:53 +08:00
2017-02-08 15:56:28 -05:00
2019-07-24 13:16:29 -04:00
2015-05-05 20:58:20 -06:00
2019-12-15 11:44:16 +08:00
2016-01-20 19:06:23 -07:00
2019-11-02 18:00:51 +08:00
2019-09-20 20:09:19 +02:00
2020-02-05 19:33:46 -07:00
2019-07-19 11:11:09 +08:00
2020-01-07 14:37:50 +01:00
2019-04-23 20:26:43 -06:00
2020-02-05 19:33:46 -07:00
2019-10-13 23:34:43 +02:00
2019-04-22 12:06:39 -04:00
2018-09-23 21:55:30 +02:00
2020-01-24 23:06:47 +05:30
2020-01-20 15:38:16 +01:00
2019-02-20 15:27:09 +08:00
2018-06-13 07:49:12 -04:00
2018-12-06 23:26:32 -05:00
2019-12-17 06:58:19 +01:00
2019-02-09 12:50:22 -07:00
2018-10-22 13:01:27 +02:00
2019-10-14 09:31:41 +02:00
2020-01-20 15:38:16 +01:00
2020-01-24 23:06:49 +05:30
2018-12-05 06:01:35 -07:00
2017-07-23 09:24:47 -04:00
2019-11-07 18:39:16 -05:00
2018-04-06 17:04:33 -04:00
2019-08-11 16:43:41 -04:00
2019-02-02 08:19:17 -05:00
2020-01-07 16:03:01 -07:00
2019-12-02 18:23:11 -05:00
2019-08-02 11:19:14 -04:00
2019-05-20 13:50:34 +02:00
2020-01-25 12:04:36 -05:00
2020-03-09 18:11:23 -05:00
2020-02-05 19:33:46 -07:00
2019-12-15 11:44:11 +08:00
2018-10-09 04:40:27 -06:00
2019-05-20 13:50:34 +02:00
2020-02-05 19:33:46 -07:00
2019-12-06 16:44:19 -05:00
2020-03-09 08:33:16 +08:00
2016-08-17 10:25:35 +09:00
2018-07-19 16:31:37 -04:00
2020-02-05 19:33:46 -07:00
2019-02-01 16:59:12 +01:00
2019-05-21 17:33:23 -06:00
2018-07-20 15:55:05 -04:00
2018-10-09 04:40:27 -06:00
2020-01-24 23:06:49 +05:30
2020-01-21 15:56:15 +01:00
2020-02-07 22:46:35 +08:00
2018-09-28 18:26:32 +02:00
2019-12-02 18:23:09 -05:00
2019-07-19 20:14:50 +02:00