eaw/u-boot
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
Files
53e54bf50d285597c1553cdf2bd0e646fcd4dd60
u-boot/lib
History
Ilias Apalodimas 53e54bf50d efi_loader: Avoid emitting efi_var_buf to .GOT 
Atish reports that on RISC-V, accessing the EFI variables causes
a kernel panic. An objdump of the file verifies that, since the
global pointer for efi_var_buf ends up in .GOT section which is
not mapped in virtual address space for Linux.

<snip of efi_var_mem_find>

0000000000000084 <efi_var_mem_find>:
  84:   715d                    addi    sp,sp,-80

* objdump -dr
0000000000000086 <.LCFI2>:
  86:   e0a2                    sd  s0,64(sp)
  88:   fc26                    sd  s1,56(sp)
  8a:   e486                    sd  ra,72(sp)
  8c:   f84a                    sd  s2,48(sp)
  8e:   f44e                    sd  s3,40(sp)
  90:   f052                    sd  s4,32(sp)
  92:   ec56                    sd  s5,24(sp)
  94:   00000497            auipc   s1,0x0
            94: R_RISCV_GOT_HI20    efi_var_buf
  98:   0004b483            ld  s1,0(s1) # 94 <.LCFI2+0xe>
            98: R_RISCV_PCREL_LO12_I    .L0
            98: R_RISCV_RELAX   *ABS*

* objdump -t
0000000000000084 g     F .text.efi_runtime  00000000000000b8 efi_var_mem_find

With the patch applied:

* objdump -dr
0000000000000086 <.LCFI2>:
  86:   e0a2                    sd  s0,64(sp)
  88:   fc26                    sd  s1,56(sp)
  8a:   e486                    sd  ra,72(sp)
  8c:   f84a                    sd  s2,48(sp)
  8e:   f44e                    sd  s3,40(sp)
  90:   f052                    sd  s4,32(sp)
  92:   ec56                    sd  s5,24(sp)
  94:   00000497            auipc   s1,0x0
            94: R_RISCV_PCREL_HI20  .LANCHOR0
            94: R_RISCV_RELAX   *ABS*
  98:   00048493            mv  s1,s1
            98: R_RISCV_PCREL_LO12_I    .L0
            98: R_RISCV_RELAX   *ABS*

* objdump -t
0000000000000008 l     O .data.efi_runtime  0000000000000008 efi_var_buf

On arm64 this works, because there's no .GOT entries for this
and everything is converted to relative references.

* objdump -dr (identical pre-post patch, only the new function shows up)
00000000000000b4 <efi_var_mem_find>:
  b4:   aa0003ee    mov x14, x0
  b8:   9000000a    adrp    x10, 0 <efi_var_mem_compare>
            b8: R_AARCH64_ADR_PREL_PG_HI21  .data.efi_runtime
  bc:   91000140    add x0, x10, #0x0
            bc: R_AARCH64_ADD_ABS_LO12_NC   .data.efi_runtime
  c0:   aa0103ed    mov x13, x1
  c4:   79400021    ldrh    w1, [x1]
  c8:   aa0203eb    mov x11, x2
  cc:   f9400400    ldr x0, [x0, #8]
  d0:   b940100c    ldr w12, [x0, #16]
  d4:   8b0c000c    add x12, x0, x12

So let's switch efi_var_buf to static and create a helper function for
anyone that needs to update it.

Fixes: e01aed47d6 ("efi_loader: Enable run-time variable support for tee based variables")
Reported-by: Atish Patra <atishp@atishpatra.org>
Tested-by: Atish Patra <atish.patra@wdc.com>
Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
2021-01-20 08:17:17 +01:00
..
acpi
x86: Simplify acpi_device_infer_name()
2020-12-18 20:32:21 -07:00
aes
fit: cipher: aes: allow to store the IV in the FIT image
2020-10-12 21:30:37 -04:00
at91
SPDX: Convert all of our single license tags to Linux Kernel style
2018-05-07 09:34:12 -04:00
bzip2
common: Drop log.h from common header
2020-05-18 21:19:18 -04:00
crypto
crypto: Fix the logic to calculate hash with authattributes set
2020-12-31 14:41:31 +01:00
dhry
command: Remove the cmd_tbl_t typedef
2020-05-18 18:36:55 -04:00
efi
serial: Update NS16550_t and struct NS16550
2021-01-05 12:24:40 -07:00
efi_driver
dm: treewide: Rename ..._platdata variables to just ..._plat
2020-12-13 16:51:09 -07:00
efi_loader
efi_loader: Avoid emitting efi_var_buf to .GOT
2021-01-20 08:17:17 +01:00
efi_selftest
efi_selftest: use CRLF as line endings in dtbdump
2021-01-20 08:17:17 +01:00
libavb
common: Drop log.h from common header
2020-05-18 21:19:18 -04:00
libfdt
fdt_region: move fdt_region.c to common/ from lib/libfdt/
2020-04-26 14:23:55 -06:00
lzma
common: Drop log.h from common header
2020-05-18 21:19:18 -04:00
lzo
SPDX: Convert all of our single license tags to Linux Kernel style
2018-05-07 09:34:12 -04:00
optee
optee: add property no-map to secure reserved memory
2020-09-22 12:54:13 -06:00
rsa
xilinx: zynq: Change types from u32 to uint32_t
2020-10-27 08:13:33 +01:00
tizen
SPDX: Convert all of our single license tags to Linux Kernel style
2018-05-07 09:34:12 -04:00
zlib
lib: zlib: our putc() takes only one argument
2021-01-16 19:17:11 -05:00
zstd
dm: core: Create a new header file for 'compat' features
2020-02-05 19:33:46 -07:00
.gitignore
lib: ignore oid_registry_data.c file
2020-01-22 17:47:57 -05:00
addr_map.c
SPDX: Convert all of our single license tags to Linux Kernel style
2018-05-07 09:34:12 -04:00
aes.c
lib: aes: build failure with DEBUG=1
2021-01-16 19:17:11 -05:00
asm-offsets.c
common: Drop asm_offsets.h from common header
2020-05-18 21:19:23 -04:00
asn1_decoder.c
common: Drop log.h from common header
2020-05-18 21:19:18 -04:00
bch.c
common: Drop log.h from common header
2020-05-18 21:19:18 -04:00
binman.c
binman: Remove additional backslash
2020-11-30 13:14:43 -07:00
bitrev.c
lib: bitrev: Sync with Linux kernel v4.17
2018-09-18 00:01:18 -06:00
charset.c
charset: make u16_strnlen accessible at runtime
2020-11-29 05:18:37 +01:00
circbuf.c
common: Drop log.h from common header
2020-05-18 21:19:18 -04:00
crc7.c
…
crc8.c
common: Drop linux/crc8.h
2019-12-02 18:23:07 -05:00
crc16.c
Roll CRC16-CCITT into the hash infrastructure
2018-12-08 20:18:44 -05:00
crc32.c
crc32: Use the crc.h header for crc functions
2019-12-02 18:23:08 -05:00
crc32c.c
SPDX: Convert all of our single license tags to Linux Kernel style
2018-05-07 09:34:12 -04:00
ctype.c
SPDX: Convert all of our single license tags to Linux Kernel style
2018-05-07 09:34:12 -04:00
date.c
lib: add mktime64() for linux compatibility
2019-12-06 16:44:19 -05:00
display_options.c
lib: print_freq() should output kHz not KHz
2020-10-22 09:54:54 -04:00
div64.c
common: Drop linux/bitops.h from common header
2020-05-18 21:19:23 -04:00
elf.c
lib: elf: Move the generic elf loading/validating functions to lib
2020-03-03 13:08:14 +05:30
errno_str.c
lib: errno: sync error codes
2019-10-31 07:22:53 -04:00
errno.c
…
fdtdec_common.c
common: Drop log.h from common header
2020-05-18 21:19:18 -04:00
fdtdec_test.c
command: Remove the cmd_tbl_t typedef
2020-05-18 18:36:55 -04:00
fdtdec.c
fdt: Use phandle to distinguish DT nodes with same name
2020-12-22 20:39:25 -07:00
getopt.c
lib: Add getopt
2020-10-30 10:56:11 -04:00
gunzip.c
common: Drop part.h from common header
2020-05-18 17:33:33 -04:00
gzip.c
common: Move gzip functions into a new gzip header
2019-08-11 16:43:41 -04:00
hang.c
common: Move hang() to the same header as panic()
2020-01-17 17:53:40 -05:00
hashtable.c
env: Allow returning errors from hdelete_r()
2020-12-04 16:09:06 -05:00
hexdump.c
lib: do not provide hexdump in SPL
2020-04-24 10:51:32 -04:00
image-sparse.c
common: Drop log.h from common header
2020-05-18 21:19:18 -04:00
Kconfig
Merge https://gitlab.denx.de/u-boot/custodians/u-boot-riscv
2021-01-18 08:04:28 -05:00
ldiv.c
SPDX: Convert all of our single license tags to Linux Kernel style
2018-05-07 09:34:12 -04:00
linux_compat.c
common: Drop net.h from common header
2020-05-18 17:33:31 -04:00
linux_string.c
…
list_sort.c
common: Drop log.h from common header
2020-05-18 21:19:18 -04:00
lmb.c
CONFIG_NR_DRAM_BANKS: Remove unreferenced code as its always defined
2020-08-26 09:19:16 +02:00
lz4_wrapper.c
lz4: fix decompressor on big-endian powerpc
2020-07-17 08:45:29 -04:00
lz4.c
SPDX: Convert a few files that were missed before
2018-05-10 20:38:35 -04:00
Makefile
smbios: add parsing API
2020-11-05 14:58:45 +08:00
md5.c
…
membuff.c
common: Drop log.h from common header
2020-05-18 21:19:18 -04:00
net_utils.c
common: Drop net.h from common header
2020-05-18 17:33:31 -04:00
of_live.c
common: Drop log.h from common header
2020-05-18 21:19:18 -04:00
oid_registry.c
lib: add oid registry utility
2019-12-06 16:44:20 -05:00
panic.c
common: Drop linux/delay.h from common header
2020-05-18 21:19:23 -04:00
physmem.c
common: Drop log.h from common header
2020-05-18 21:19:18 -04:00
qsort.c
common: Drop log.h from common header
2020-05-18 21:19:18 -04:00
rand.c
common: Move random-number functions into their own header
2019-12-02 18:23:07 -05:00
rbtree.c
SPDX: Convert all of our single license tags to Linux Kernel style
2018-05-07 09:34:12 -04:00
rc4.c
SPDX: Convert all of our single license tags to Linux Kernel style
2018-05-07 09:34:12 -04:00
sha1.c
SPDX: Convert all of our single license tags to Linux Kernel style
2018-05-07 09:34:12 -04:00
sha256.c
SPDX: Convert all of our single license tags to Linux Kernel style
2018-05-07 09:34:12 -04:00
sha512.c
Add support for SHA384 and SHA512
2020-06-12 13:14:07 -04:00
slre.c
common: Drop log.h from common header
2020-05-18 21:19:18 -04:00
smbios-parser.c
smbios: add parsing API
2020-11-05 14:58:45 +08:00
smbios.c
dm: treewide: Rename ..._platdata variables to just ..._plat
2020-12-13 16:51:09 -07:00
sscanf.c
xen: Code style conformity
2020-08-24 14:11:31 -04:00
string.c
string: Use memcpy() within memmove() when we can
2021-01-16 14:49:09 -05:00
strto.c
Revert "lib: Improve _parse_integer_fixup_radix base 16 detection"
2020-06-15 11:23:41 -04:00
tables_csum.c
SPDX: Convert all of our single license tags to Linux Kernel style
2018-05-07 09:34:12 -04:00
time.c
timer: Use a shorter error in TPL
2021-01-05 12:24:40 -07:00
tiny-printf.c
tiny-printf: Support %i
2020-05-01 11:03:24 -04:00
tpm-common.c
common: Drop log.h from common header
2020-05-18 21:19:18 -04:00
tpm-utils.h
tpm: Convert to use a device parameter
2018-11-29 09:30:06 -07:00
tpm-v1.c
common: Drop log.h from common header
2020-05-18 21:19:18 -04:00
tpm-v2.c
tpm: use more than sha256 on pcr_extend
2020-12-03 21:22:40 +01:00
trace.c
trace: conserve gd register on RISC-V
2020-10-27 21:13:15 +01:00
uuid.c
doc/README.gpt: define partition type GUID for U-Boot environment
2021-01-16 14:49:09 -05:00
vsprintf.c
compiler*.h: sync include/linux/compiler*.h with Linux 5.7-rc5
2020-07-01 11:48:05 -04:00
xxhash.c
lib: Add xxhash support
2019-05-05 08:48:50 -04:00