arm: Don't include common.h in header files
It is bad practice to include common.h in other header files since it can bring in any number of superfluous definitions. It implies that some C files don't include it and thus may be missing CONFIG options that are set up by that file. The C files should include these themselves. Update some header files in arch/arm to drop this. Signed-off-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
@@ -1,6 +1,7 @@
|
||||
#ifndef _LINUX_COMPAT_H_
|
||||
#define _LINUX_COMPAT_H_
|
||||
|
||||
#include <log.h>
|
||||
#include <malloc.h>
|
||||
#include <linux/types.h>
|
||||
#include <linux/err.h>
|
||||
|
||||
@@ -16,6 +16,7 @@
|
||||
#include <config.h>
|
||||
|
||||
#include <dm/device.h>
|
||||
#include <linux/bitops.h>
|
||||
#include <linux/compat.h>
|
||||
#include <linux/mtd/mtd.h>
|
||||
#include <linux/mtd/flashchip.h>
|
||||
|
||||
@@ -15,9 +15,13 @@
|
||||
#include <asm/cache.h>
|
||||
#include <asm/byteorder.h> /* for nton* / ntoh* stuff */
|
||||
#include <env.h>
|
||||
#include <log.h>
|
||||
#include <time.h>
|
||||
#include <linux/if_ether.h>
|
||||
#include <rand.h>
|
||||
|
||||
struct cmd_tbl_s;
|
||||
|
||||
#define DEBUG_LL_STATE 0 /* Link local state machine changes */
|
||||
#define DEBUG_DEV_PKT 0 /* Packets or info directed to the device */
|
||||
#define DEBUG_NET_PKT 0 /* Packets on info on the network at large */
|
||||
@@ -59,7 +63,7 @@ struct in_addr {
|
||||
* @argv: List of arguments
|
||||
* @return result (see enum command_ret_t)
|
||||
*/
|
||||
int do_tftpb(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]);
|
||||
int do_tftpb(struct cmd_tbl_s *cmdtp, int flag, int argc, char *const argv[]);
|
||||
|
||||
/**
|
||||
* An incoming packet handler.
|
||||
|
||||
@@ -26,6 +26,8 @@ struct image_header;
|
||||
#define MMCSD_MODE_FS 2
|
||||
#define MMCSD_MODE_EMMCBOOT 3
|
||||
|
||||
struct image_header;
|
||||
|
||||
/*
|
||||
* u_boot_first_phase() - check if this is the first U-Boot phase
|
||||
*
|
||||
|
||||
Reference in New Issue
Block a user