eaw/esp-idf
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

esp_https_ota: Added error checking functionalities.

Browse Source 
Current implimentation of esp_http_ota does not perform any error-checking in the data writing phase calls `esp_ota_get_next_update_partition()` irrespetive of the received state of the image. A few additional error checking mechanism have now been added inside the esp_https_ota which returns the control in case an invalid header is received and a wrapper to the function `esp_http_client_is_complete_data_received()` of `esp_http_client` has been added.
This commit is contained in:
Hrudaynath Dhabe
2019-08-15 21:10:00 +08:00
committed by maojianxin
parent a749488f9f
commit fbfad8838e
4 changed files with 38 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
examples/system/ota/advanced_https_ota/main/advanced_https_ota_example.c
View File

@@ -142,6 +142,11 @@ void advanced_ota_example_task(void * pvParameter)
ESP_LOGD(TAG, "Image bytes read: %d", esp_https_ota_get_image_len_read(https_ota_handle));
}
if (esp_https_ota_is_complete_data_received(&https_ota_handle) != true) {
// the OTA image was not completely received and user can customise the response to this situation.
ESP_LOGE(TAG, "Complete data was not received.");
}
ota_end:
ota_finish_err = esp_https_ota_finish(https_ota_handle);
if ((err == ESP_OK) && (ota_finish_err == ESP_OK)) {

5
examples/system/ota/native_ota_example/main/native_ota_example.c
View File

@@ -243,6 +243,11 @@ static void ota_example_task(void *pvParameter)
}
}
ESP_LOGI(TAG, "Total Write binary data length : %d", binary_file_length);
if (esp_http_client_is_complete_data_received(client) != true) {
ESP_LOGE(TAG, "Error in receiving complete file");
http_cleanup(client);
task_fatal_error();
}
if (esp_ota_end(update_handle) != ESP_OK) {
ESP_LOGE(TAG, "esp_ota_end failed!");